[Webkit-unassigned] [Bug 132911] sourceFrameOnScreenForShareItem: can be off by a pixel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132911


Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |beidson at apple.com
                   |kit.org                     |
 Attachment #231456|                            |review?
               Flag|                            |




--- Comment #1 from Brady Eidson <beidson at apple.com>  2014-05-14 10:22:26 PST ---
Created an attachment (id=231456)
 --> (https://bugs.webkit.org/attachment.cgi?id=231456&action=review)
Patch v1

This splits off the client rect calculation into a utility method (which will also be used in bug 132912), and that method is guaranteed to keep everything in terms of floats.

Only a single rounding conversion from Float->Int rect takes place.

This fixes the known cases of off-by-one-pixel errors.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.