[Webkit-unassigned] [Bug 132846] ResourceLoadTiming should use reference instead of pointer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 14 10:08:52 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=132846


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231406|review?                     |review+
               Flag|                            |




--- Comment #9 from Alexey Proskuryakov <ap at webkit.org>  2014-05-14 10:09:12 PST ---
(From update of attachment 231406)
View in context: https://bugs.webkit.org/attachment.cgi?id=231406&action=review

And the downside is of course that touching ResourceTiming header will make half of WebCore rebuild, because half of WebCore indirectly includes ResourceResponse.h.

> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm:197
> +        timing.domainLookupStart = domainLookupStart <= 0.0 ? -1 : (domainLookupStart - referenceStart) * 1000;

I don't think that we ever need to compare to 0.0, can it be simply 0?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list