[Webkit-unassigned] [Bug 132900] GIF animations don't restart after scrolling on iOS WebKit1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 14 09:24:02 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=132900





--- Comment #4 from Darin Adler <darin at apple.com>  2014-05-14 09:24:24 PST ---
(From update of attachment 231438)
View in context: https://bugs.webkit.org/attachment.cgi?id=231438&action=review

>> Source/WebKit/mac/WebView/WebView.mm:1581
>> +    FrameView* view = [self _mainCoreFrame]->view();
> 
> I think "FrameView *view" is the appropriate style here.

No, the style is right. We do that different formatting thing with * only for Objective-C types, not for C++ types like FrameView.

We should probably change the rule though. The only place where we need the "X *" style is in public Objective-C headers. Inside the code it would be easier if we adopted a consistent rule.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list