[Webkit-unassigned] [Bug 132527] AX: [ATK] [PATCH] add text-caret-moved signal to accessibilityController

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 14 02:11:38 PDT 2014


--- Comment #9 from Mario Sanchez Prada <mario at webkit.org>  2014-05-14 02:11:58 PST ---
(In reply to comment #8)
> Created an attachment (id=231399)
 --> (https://bugs.webkit.org/attachment.cgi?id=231399&action=review) [details]
> caret-moved signal and caret offset tests
> Hi Mario. This is bigger, as you suggested. Thanks in advance for your review!

Thanks for the patch Jarek, it definitely looks like a better approach after a quick glance over it!

Still, before I do a proper review, would you mind rebasing your patch against trunk and uploading it again? Asking that because the patch does not currently apply on trunk, which is preventing the style and EWS bots from running, which would be helpful if they did.

Once you do that, I promise I'll find time during this crazy week to review it properly :)

Thanks again!

PS: I've tried to apply it locally to make sure it did not apply and this is the rejection that I got:

--- Source/WebCore/page/ViewportConfiguration.cpp       (revision 0)
+++ Source/WebCore/page/ViewportConfiguration.cpp       (working copy)
@@ -26,8 +26,10 @@
 #include "config.h"
 #include "ViewportConfiguration.h"

+#include <WebCore/TextStream.h>
 #include <wtf/Assertions.h>
 #include <wtf/MathExtras.h>
+#include <wtf/text/CString.h>

 #include "WebCoreSystemInterface.h"

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list