[Webkit-unassigned] [Bug 132889] REGRESSION (topContentInset): Searching through Facebook Messenger's chat causes scrolling in News Feed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132889


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231412|review?                     |review+
               Flag|                            |




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-05-13 15:37:11 PST ---
(From update of attachment 231412)
View in context: https://bugs.webkit.org/attachment.cgi?id=231412&action=review

> Source/WebCore/platform/ScrollView.cpp:430
> +    IntSize scrollOffset = this->scrollOffset();
> +    return IntSize(scrollOffset.width(), scrollOffset.height() - headerHeight());

return scrollOffset() - IntSize(0, headerHeight) ?

> Source/WebCore/platform/ScrollView.h:244
> +    // scrollOffset() anchors its (0,0) point at the top end of the scolling layer. When the Page

Seems odd for a comment in ScrollView.h to be talking about layers, since this is below the level of layer stuff. "at the top end" is odd too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.