[Webkit-unassigned] [Bug 132846] ResourceLoadTiming should use reference instead of pointer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132846


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231386|review?                     |review-
               Flag|                            |




--- Comment #6 from Anders Carlsson <andersca at apple.com>  2014-05-13 13:58:07 PST ---
(From update of attachment 231386)
View in context: https://bugs.webkit.org/attachment.cgi?id=231386&action=review

Is there a reason why you can't just have an std::unique_ptr reference to the ResourceLoadTiming object? Maybe it doesn't matter.
r- because of the assignment operator.

> Source/WebCore/platform/network/ResourceLoadTiming.h:65
> +    void operator=(const ResourceLoadTiming& other)
> +    {
> +        domainLookupStart = other.domainLookupStart;
> +        domainLookupEnd = other.domainLookupEnd;
> +        connectStart = other.connectStart;
> +        connectEnd = other.connectEnd;
> +        requestStart = other.requestStart;
> +        responseStart = other.responseStart;
> +        secureConnectionStart = other.secureConnectionStart;
> +    }

This is not a correct assignment operator, it needs to return *this.

> Source/WebCore/platform/network/ResourceResponseBase.cpp:555
>      lazyInit(CommonAndUncommonFields);

Do we need to call this now?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.