[Webkit-unassigned] [Bug 132863] Remove BLOB guards

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 13 10:18:18 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=132863


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231371|review?                     |review-
               Flag|                            |




--- Comment #10 from Alexey Proskuryakov <ap at webkit.org>  2014-05-13 10:18:37 PST ---
(From update of attachment 231371)
View in context: https://bugs.webkit.org/attachment.cgi?id=231371&action=review

Windows port doesn't enable blobs. I don't know why, perhaps it should. I'd certainly be super happy to have Blobs enabled unconditionally, it is very annoying and cofusing that some blob related code is enabled, and some is not.

> Source/WebCore/WebCore.exp.in:-2865
> -#if ENABLE(BLOB)
>  __ZN7WebCore12BlobRegistryD2Ev
>  __ZN7WebCore12blobRegistryEv
>  __ZN7WebCore14LoaderStrategy18createBlobRegistryEv
>  __ZTVN7WebCore12BlobRegistryE
>  __ZTVN7WebCore16BlobRegistryImplE
> -#endif

This file is alphabetically sorted, except for conditional exports. Could you please move these lines up to maintain the rule?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list