[Webkit-unassigned] [Bug 132870] ASSERTION FAILED: leftCategory != CalcOther && rightCategory != CalcOther in WebCore::CSSCalcBinaryOperation::createSimplified

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132870


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231384|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2014-05-13 09:38:02 PST ---
(From update of attachment 231384)
View in context: https://bugs.webkit.org/attachment.cgi?id=231384&action=review

> LayoutTests/ChangeLog:8
> +        Added test contains calc() expressions with angle, time and frequency values,
> +        covering all the newly introduced unit types, each of which used to fail. 

But it doesn’t cover adding or subtracting combinations of these unit types, and the patch adds code to handle that.

It doesn’t cover the behavior either. Need much more test coverage.

I’d also like to see tests covering serialization of these kinds of style rules.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.