[Webkit-unassigned] [Bug 132671] [GStreamer] A video element isn't drawn onto the canvas.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132671





--- Comment #11 from Philippe Normand <pnormand at igalia.com>  2014-05-13 02:45:37 PST ---
(In reply to comment #1)
> Created an attachment (id=231047)
 --> (https://bugs.webkit.org/attachment.cgi?id=231047&action=review) [details]
> example

Thanks for the patch, it indeed works :) Can a layout test be unskipped thanks to the fix? 

(In reply to comment #4)
> (In reply to comment #2)
> > This is a regression of below.
> > https://bugs.webkit.org/show_bug.cgi?id=86410
> > 
> > 
> > (WebCore::MediaPlayerPrivateGStreamerBase::paint) is used for 'drawImage'.
> > But when accelerated compositing is used, this function didn't work.
> > 
> > 
> > This exception for AC is still needed?
> 
> In AC the video is painted using GL textures. Look at 
> 
> void MediaPlayerPrivateGStreamerBase::paintToTextureMapper(TextureMapper* textureMapper, const FloatRect& targetRect, const TransformationMatrix& matrix, float opacity)
> 
> If AC is not used, the painting is done through Cairo, and it's when this method is used.
> 
> In AC we wait for the TextureMapper update to paint the video buffer in the texture.
> 
> Removing this guard will mean to mix approaches, and that's not sane.

::paint is no longer used indeed excepted in this case, whatever if AC is disabled or not. I think this patch is ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.