[Webkit-unassigned] [Bug 38943] Input ::selection pseudo class does not work leading to hidden selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38943





--- Comment #9 from Darin Adler <darin at apple.com>  2014-05-12 17:54:12 PST ---
(From update of attachment 231262)
View in context: https://bugs.webkit.org/attachment.cgi?id=231262&action=review

>> LayoutTests/fast/selectors/input-with-selection-pseudo-element.html:3
>> +    ::selection { background-color: rgba(63, 128, 33, 0.95); color: yellow; }
> 
> Why does the green have a bit of alpha in it? It seems to complicate the test without adding value. Why not just "green"?

This comment is still not addressed in the latest patch.

>> LayoutTests/fast/selectors/input-with-selection-pseudo-element.html:8
>> +<br>The above selected text in the input box should have green background and yellow color.
> 
> Why the <br>?
> 
> A better test would say a word or two about what it’s testing rather than simply describing what success looks like.

Unfortunately you took my direction too literally. It’s great to also have the test describe what success looks like. I was suggesting including both.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.