[Webkit-unassigned] [Bug 63153] SVG root element accepts background color but fails to repaint it

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63153


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231335|review?                     |review+
               Flag|                            |




--- Comment #4 from Dean Jackson <dino at apple.com>  2014-05-12 16:10:26 PST ---
(From update of attachment 231335)
View in context: https://bugs.webkit.org/attachment.cgi?id=231335&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:193
> +bool RenderBoxModelObject::calculateHasBoxDecorations() const

I don't like this name. What is being "calculated"? It's not returning a number.

If you keep this name, then I think it should return void and set m_hasBoxDecorations, or something like that. I guess it depends on how you are using it.

> Source/WebCore/rendering/svg/RenderSVGRoot.cpp:240
> +    // SVG outlines are painted during PaintPhaseForeground.
> +    if (paintInfo.phase == PaintPhaseOutline || paintInfo.phase == PaintPhaseSelfOutline)
> +        return;
> +

Is that from the previous patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.