[Webkit-unassigned] [Bug 132574] clean up ResourceLoadTiming

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132574


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231322|review?                     |review+
               Flag|                            |




--- Comment #29 from Alexey Proskuryakov <ap at webkit.org>  2014-05-12 14:21:04 PST ---
(From update of attachment 231322)
View in context: https://bugs.webkit.org/attachment.cgi?id=231322&action=review

> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm:199
> +        if (timing) {

You actually just create ResourceLoadTiming above, so the null check is misleading. The right way to do this is to use this idiom:

ResourceLoadTiming* resourceLoadTimingIfExists()
ResourceLoadTiming& resourceLoadTiming()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.