[Webkit-unassigned] [Bug 132574] clean up ResourceLoadTiming
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 12 11:11:12 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=132574
Alexey Proskuryakov <ap at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #231298|review? |review+
Flag| |
--- Comment #25 from Alexey Proskuryakov <ap at webkit.org> 2014-05-12 11:11:30 PST ---
(From update of attachment 231298)
View in context: https://bugs.webkit.org/attachment.cgi?id=231298&action=review
> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:224
> +#if ENABLE(WEB_TIMING)
This is all needed in WebCoreResourceHandleAsDelegate.mm, too. There is no reason to have it work incorrectly in WebKitLegacy.
> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:226
> + NSDictionary* timingData = [connection _timingData];
> + if (timingData) {
Style nit: star goes to the other side for Objective-C, and you could combine the definition with if:
if (NSDictionary *timingData = [connection _timingData])
...
> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:228
> + ResourceLoadTiming* timing = resourceResponse.resourceLoadTiming();
It seems strange to see a pointer variable used without a null check, or any obvious reason why it can't be null. Can the function return a reference?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list