[Webkit-unassigned] [Bug 132819] [GTK] CMAKE_INSTALL_LIBDIR incorrectly set when LIB_INSTALL_DIR is used

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132819





--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-05-12 08:57:31 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > (From update of attachment 231292 [details] [details] [details])
> > > I don't see LIB_INSTALL_DIR anywhere in the CMake documentation. Why would one pass it to CMake?
> > 
> > I think I found it in the jhbuild cmake code.
> 
> Looks like it is something that was added especially for the WebKit build.

No, I'm talking about the generic cmake support in jhbuild, it was added in 2010, see

https://git.gnome.org/browse/jhbuild/commit/?id=d665c74f984163e34f4ac2f5c273fd9cbf56e7af

> I wonder if the right thing to do here is for users to pass CMAKE_INSTALL_LIBDIR instead. We either need to override all the GNU variable's (CMAKE_INSTALL_FOO) manually or just rely on users passing them directly. Hard for me to say what is the right thing.

All other CMAKE_INSTALL_FOO variables seems to be correctly set by GNUInstallDirs, because they correctly combine the relative path with the CMAKE_INSTALL_PREFIX. But for the CMAKE_INSTALL_LIBDIR there's a special case to deal with lib vs lib64 and some other distro specific things. I'm not sure if it's possible to pass CMAKE_INSTALL_LIBDIR instead of LIB_INSTALL_DIR as cmakeargs, but I guess LIB_INSTALL_DIR exists for a reason. Even if change my build script to pass CMAKE_INSTALL_LIBDIR, tarballs won't work in jhbuild.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.