[Webkit-unassigned] [Bug 132574] clean up ResourceLoadTiming

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132574


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231195|review?                     |review-
               Flag|                            |




--- Comment #23 from Sam Weinig <sam at webkit.org>  2014-05-10 13:46:09 PST ---
(From update of attachment 231195)
View in context: https://bugs.webkit.org/attachment.cgi?id=231195&action=review

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:702
> +    ResourceLoadTiming* timing = resourceResponse.resourceLoadTiming();
> +    bool hasResourceLoadTiming = timing;
> +    encoder << hasResourceLoadTiming;
> +    if (hasResourceLoadTiming) {
> +        encoder << timing->domainLookupStart;
> +        encoder << timing->domainLookupEnd;
> +        encoder << timing->connectStart;
> +        encoder << timing->connectEnd;
> +        encoder << timing->requestStart;
> +        encoder << timing->responseStart;
> +        encoder << timing->secureConnectionStart;
> +    }

This should probably be wrapped in an #if ENABLE(WEB_TIMING).

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:785
> +    bool hasResourceLoadTiming;
> +    if (!decoder.decode(hasResourceLoadTiming))
> +        return false;
> +    if (hasResourceLoadTiming) {
> +        response.setResourceLoadTiming(ResourceLoadTiming::create());
> +        ResourceLoadTiming* timing = response.resourceLoadTiming();
> +        if (!decoder.decode(timing->domainLookupStart)
> +            || !decoder.decode(timing->domainLookupEnd)
> +            || !decoder.decode(timing->connectStart)
> +            || !decoder.decode(timing->connectEnd)
> +            || !decoder.decode(timing->requestStart)
> +            || !decoder.decode(timing->responseStart)
> +            || !decoder.decode(timing->secureConnectionStart))
> +            return false;
> +    }

This should probably be wrapped in an #if ENABLE(WEB_TIMING).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.