[Webkit-unassigned] [Bug 128985] WebGL EXT_shader_texture_lod may be implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128985





--- Comment #9 from Dean Jackson <dino at apple.com>  2014-05-09 13:43:18 PST ---
> > (In reply to comment #6)
> > > I think we also need to set EXT_shader_texture_lod in ShBuiltInResources when we initialise ANGLE in GraphicsContext3D
> > Do you mean in Extensions3DOpenGLCommon::ensureEnabled?
> 
> No. I think that we need to pass in a flag to ANGLE to tell it that it can use the LOD built-ins in the Shader validator, otherwise the GLSL will be rejected.
> 
> See, ShaderLang.h
> 
>     // Extensions.
>     // Set to 1 to enable the extension, else 0.
>     int OES_standard_derivatives;
>     int OES_EGL_image_external;
>     int ARB_texture_rectangle;
>     int EXT_draw_buffers;
>     int EXT_frag_depth;
>     int EXT_shader_texture_lod;
> 
> in ShBuiltInResources. We just need to set that when we create the validator.

Duh! Yes, that *is* where it should go, sorry. Extensions3DOpenGLCommon::ensureEnabled

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.