[Webkit-unassigned] [Bug 132686] REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 9 09:44:40 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=132686
--- Comment #2 from Martin Robinson <mrobinson at webkit.org> 2014-05-09 09:45:02 PST ---
(From update of attachment 231148)
View in context: https://bugs.webkit.org/attachment.cgi?id=231148&action=review
> Tools/ChangeLog:9
> + a single binary TestWebCore with the other Webcore tests. Also
Super nit: Webcore -> WebCore
> Tools/TestWebKitAPI/PlatformGTK.cmake:125
> -set(test_webcore_BINARIES
> - LayoutUnit
> - URL
> +add_executable(TestWebCore
> + ${test_main_SOURCES}
> + ${TestWebCoreGtk_SOURCES}
> + ${TESTWEBKITAPI_DIR}/TestsController.cpp
> + ${TESTWEBKITAPI_DIR}/Tests/WebCore/LayoutUnit.cpp
> + ${TESTWEBKITAPI_DIR}/Tests/WebCore/URL.cpp
> )
I think if we are going to go our own way on all of these unit tests, we should just stop using the shared CMakeLists.txt.
> Tools/TestWebKitAPI/PlatformGTK.cmake:130
> +add_test(TestWebCore ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebCore/TestWebCore)
> +set_tests_properties(TestWebCore PROPERTIES TIMEOUT 60)
> +set_target_properties(TestWebCore PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebCore)
We don't need these lines unless we plan to use 'make test.'
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list