[Webkit-unassigned] [Bug 128985] WebGL EXT_shader_texture_lod may be implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128985


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231094|review?                     |review-
               Flag|                            |




--- Comment #5 from Dean Jackson <dino at apple.com>  2014-05-08 17:44:39 PST ---
(From update of attachment 231094)
View in context: https://bugs.webkit.org/attachment.cgi?id=231094&action=review

We definitely need a test. There is nothing in the official testsuite :(
This means you'll have to write something from scratch. For now, copy the existing approach in LayoutTests/webgl and we'll submit the test to khronos when done.

And yes, we have the ANGLE fixes.

> Source/WebCore/ChangeLog:12
> +        * WebCore.vcxproj/WebCore.vcxproj:

Don't we also add to the .filters file?

> Source/WebCore/CMakeLists.txt:2941
>  list(APPEND WebCore_SOURCES
> +    platform/text/TextCodecICU.cpp
> +    platform/text/TextEncodingDetectorICU.cpp
>      platform/text/icu/UTextProvider.cpp
>      platform/text/icu/UTextProviderLatin1.cpp
>      platform/text/icu/UTextProviderUTF16.cpp
> -    platform/text/TextCodecICU.cpp
> -    platform/text/TextEncodingDetectorICU.cpp
>  )

Was this intentional?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.