[Webkit-unassigned] [Bug 132112] Web Inspector: Selecting frame in debugger sidebar doesn't reveal code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132112





--- Comment #11 from Timothy Hatcher <timothy at apple.com>  2014-05-08 15:09:07 PST ---
(From update of attachment 231085)
View in context: https://bugs.webkit.org/attachment.cgi?id=231085&action=review

> Source/WebInspectorUI/ChangeLog:10
> +        base getter elementIsSelected to NavigationSidebarPanel and extended it in 

"getter" should be "function" with the change below.

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:135
> +    get hasSelectedElement()
> +    {
> +        return !!this._breakpointsContentTreeOutline.selectedTreeElement || !!this._callStackContentTreeOutline.selectedTreeElement;
> +    },

We don't use verb prefixes with getters. This should be a plain function.

> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:150
> +    get hasSelectedElement()

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.