[Webkit-unassigned] [Bug 132112] Web Inspector: Selecting frame in debugger sidebar doesn't reveal code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132112


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231026|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org>  2014-05-08 11:30:07 PST ---
(From update of attachment 231026)
View in context: https://bugs.webkit.org/attachment.cgi?id=231026&action=review

r=me with some comments

> Source/WebInspectorUI/ChangeLog:8
> +        `WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar` was checking

No need for all the backticks here.

> Source/WebInspectorUI/UserInterface/Base/Main.js:925
> +    if (!selectedSidebarPanel.elementIsSelected)

I think the name "elementIsSelected" is weird. Maybe "hasSelectedElement" or "hasSelection"?

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:132
> +    get elementIsSelected() {

Style: Brace on newline.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.