[Webkit-unassigned] [Bug 132681] [GTK] Use a different user agent string depending on the site

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132681





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-05-08 10:30:29 PST ---
(In reply to comment #5)
> (From update of attachment 231068 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231068&action=review
> 
> I like the patch. My only concern is having to add new broken sites to the code as we find them, but I guess we've lost the race for the works-for-all-sites UA many times.

Yes.

> > Source/WebCore/platform/gtk/UserAgentGtk.cpp:146
> > +        uaString.appendLiteral(" Version/6.0");
> 
> Some users reported that some sites where complaining about using an old Safari version. Should we use 7.0 (or the most recent one)?

I don't know, I didn't want to change the current behaviour for the specific sites that caused the UA changes.

> > Source/WebCore/platform/gtk/UserAgentGtk.cpp:189
> > +    }
> 
> We used to have rules also for google domains in WK1. Time to resurrect them?

Yes, but again, I wanted this patch to fix the sites that required to change the UA string lately, and at the same time fix all other sites that don't require it and were doing weird things, like bugzilla setting your OS as MAC OS or sites that offer the mac download instead of the linux one. 

Once this patch lands, we can add new specific site quirks like google sites easily.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.