[Webkit-unassigned] [Bug 132678] [EFL] Fix build error in blob.cpp after r168435

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 8 09:29:58 PDT 2014


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #231056|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2014-05-08 09:30:20 PST ---
(From update of attachment 231056)
View in context: https://bugs.webkit.org/attachment.cgi?id=231056&action=review

Sorry for the breakage - efl-wk2 bot was green, and efl one does not work.

> Source/WebCore/fileapi/Blob.cpp:127
> -        m_size = (actualSize <= std::numeric_limits<long long>::max()) ? static_cast<long long>(actualSize) : 0;
> +        m_size = (actualSize <= std::numeric_limits<unsigned long long>::max()) ? static_cast<long long>(actualSize) : 0;

The purpose of this check is to verify that the number fits into long long - we already know that it fits into an unsigned long long!

if it complains about signed/unsigned comparison, you probably need something like

actualSize <= static_cast<unsigned long long>(std::numeric_limits<long long>::max()))

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list