[Webkit-unassigned] [Bug 132671] [GStreamer] A video element isn't drawn onto the canvas.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132671





--- Comment #8 from Víctor M. Jáquez L. <vjaquez at igalia.com>  2014-05-08 02:34:02 PST ---
(From update of attachment 231048)
View in context: https://bugs.webkit.org/attachment.cgi?id=231048&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:-350
> -        return;

What about, instead of removing this code, and instead or a simple return,  we do

    if (supportsAcceleratedRendering() && m_player->mediaPlayerClient()->mediaPlayerRenderingCanBeAccelerated(m_player) && client()) {
        client()->setPlatformLayerNeedsDisplay();
        return;
    }

just as in void MediaPlayerPrivateGStreamerBase::triggerRepaint(GstBuffer* buffer)

--- Comment #9 from Víctor M. Jáquez L. <vjaquez at igalia.com>  2014-05-08 02:34:06 PST ---
(From update of attachment 231048)
View in context: https://bugs.webkit.org/attachment.cgi?id=231048&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:-350
> -        return;

What about, instead of removing this code, and instead or a simple return,  we do

    if (supportsAcceleratedRendering() && m_player->mediaPlayerClient()->mediaPlayerRenderingCanBeAccelerated(m_player) && client()) {
        client()->setPlatformLayerNeedsDisplay();
        return;
    }

just as in void MediaPlayerPrivateGStreamerBase::triggerRepaint(GstBuffer* buffer)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.