[Webkit-unassigned] [Bug 132574] clean up ResourceLoadTiming

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132574


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231004|review?                     |review-
               Flag|                            |




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org>  2014-05-07 14:11:18 PST ---
(From update of attachment 231004)
View in context: https://bugs.webkit.org/attachment.cgi?id=231004&action=review

Yes, the situation with monotonic times doesn't seem right. Discussing in person.

> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:220
> +#if __has_include(<CFNetwork/CFNSURLConnection.h>)
> +        ResourceResponse resourceResponse(r);

Open source builds should not magically have the feature broken. What we should do is re-declare _timingData as a category, and have the code under if ENABLE(RESOURCE_TIMING).

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:806
> +    

Spurious whitespace!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.