[Webkit-unassigned] [Bug 132643] Fix build errors for BlobDataItem after r168391
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 7 00:01:46 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=132643
Carlos Garcia Campos <cgarcia at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #230974|review?, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> 2014-05-07 00:02:00 PST ---
(From update of attachment 230974)
View in context: https://bugs.webkit.org/attachment.cgi?id=230974&action=review
> Source/WebCore/ChangeLog:6
> + Build error fix.
This doesn't provide any useful information, since the summary already says Fix build errors ...
> Source/WebCore/ChangeLog:10
> + No new tests. No change in behaviour.
You should remove this, commit-queue will refuse to commit this if this line is present in the changelog.
> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:783
> soup_message_body_append(message->request_body, SOUP_MEMORY_TEMPORARY,
> - blobItem.data->data() + blobItem.offset, blobItem.length);
> + blobItem.data->data() + blobItem.offset(), blobItem.length());
Even if this was already using the old coding style, we can take advantage we are changing it now to use the new coding style, please fix it.
> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:794
> - blobItem.path,
> - blobItem.offset,
> - blobItem.length == BlobDataItem::toEndOfFile ? 0 : blobItem.length,
> + blobItem.file->path(),
> + blobItem.offset(),
> + blobItem.length() == BlobDataItem::toEndOfFile ? 0 : blobItem.length(),
Ditto.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list