[Webkit-unassigned] [Bug 132527] AX: [ATK] [PATCH] add text-caret-moved signal to accessibilityController

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 6 06:45:41 PDT 2014


--- Comment #5 from Jarek Czekalski <jarekczek at poczta.onet.pl>  2014-05-06 06:46:01 PST ---
Hi Mario,

Thank you for the review.

(In reply to comment #3)
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:93
> > +    AtkRole objectRole = atk_object_get_role(accessible);
> > +    const gchar* roleName = atk_role_get_name(objectRole);
> Why do you need the role and the name of the object here? This variables are used only to set the value of signalValue, which will be used only to pass it to printAccessibilityEvent(), where the role will be retrieved and printed anyway

Good catch. My intention was to pass signalValue as the 3rd parameter to event listener. But there is no 3rd parameter, I missed it.

In testatk.c we verify not only whether the signal was delivered, but if the reported offset is correct as well. I will try to provide a modification allowing to pass additional parameter to the handler.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list