[Webkit-unassigned] [Bug 130891] [CSS Blending] Blending doesn't work if the parent stacking context is not a self painting layer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130891





--- Comment #12 from Ion Rosca <rosca at adobe.com>  2014-05-06 04:30:15 PST ---
(From update of attachment 230417)
View in context: https://bugs.webkit.org/attachment.cgi?id=230417&action=review

>> Source/WebCore/ChangeLog:27
>> +        When hasUnisolatedBlendingDescendants gets set we make sure that isSelfPaintingLayer flag is set too.
> 
> I think it looks better to replace Unisolated with NotIsolated . Seems easier to read.

Ok.

>> Source/WebCore/ChangeLog:39
>> +        the assertion in hasUnisolatedBlendingDescendants() for non-stacking context elements.
> 
> Wow, there should probably a comment in RenderLayer.h to warn others.

Actually I think we should remove the ASSERT from hasUnisolatedBlendingDescendants() for now. I still hit it in some circumstances and I've heard other people complaining about that too. Asserts have been removed for the other flags as well (see comments in RenderLayer.h: https://bugs.webkit.org/show_bug.cgi?id=71044).
I hit this assertion mostly on minibrowser and in layout tests. On safari flags are updated correctly after changing the style because computeCompositingRequirements calls updateDescendantDependentFlags.

We need a generic mechanism for updating all types of dirty flags on ancestors after the style gets changed and turn the asserts back on. I will remove this change and I'll comment the assert, addressing the issue #71044 with another patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.