[Webkit-unassigned] [Bug 132555] CMake per-target property INCLUDE_DIRECTORIES incompatible with CMake 2.8.7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 5 22:25:07 PDT 2014


--- Comment #3 from Nikos Andronikos <nikos.andronikos-webkit at cisra.canon.com.au>  2014-05-05 22:25:28 PST ---
(In reply to comment #2)
> The GTK+ port would like maintain compatibility for old CMake versions as long as possible. Probably the best thing to do here is to make a macro that checks the CMake version and falls back to setting the global include directory.

>From what I understand the logic is currently structured as follows:

USE_GTK2 in Source/cmake/OptionsGTK.cmake is undefined.
Therefore, GTK_LIBRARIES, GTK_INCLUDE_DIRS etc.. are defined to use the GTK3/GDK3 libraries and include directories (Source/cmake/OptionsGTK.cmake:181).

Then, in the Source/WebCore/PlatformGTK.cmake file the following properties are set:
1. The WebCorePlatformGTK2 target uses the GTK2_INCLUDE_DIRS and GDK2_INCLUDE_DIRS
2. The WebCorePlatformGTK target uses the GTK_INCLUDE_DIRS and GDK_INCLUDE_DIRS (which are defined as GTK3/GDK3)

So if this is the required logic I am not sure that overriding with a global include directory is the right way to go.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list