[Webkit-unassigned] [Bug 132555] New: CMake per-target property INCLUDE_DIRECTORIES incompatible with CMake 2.8.7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132555

           Summary: CMake per-target property INCLUDE_DIRECTORIES
                    incompatible with CMake 2.8.7
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: nikos.andronikos-webkit at cisra.canon.com.au


Background:
My machine configuration:
Architecture: x86_64
Linux Distribution: Ubuntu 12.04
GCC/G++ version: 4.8
CMake version: 2.8.7

By tracing back the error: "fatal error: gtk/gtk.h: No such file or directory" on my system I found out that the problem is due to some cmake instructions used in the build system (more details below).

Problem:
The per-target INCLUDE_DIRECTORIES set_property command is included in numerous files.
For example, WebCore/PlatformGTK.cmake:

set_property(
    TARGET WebCorePlatformGTK
    APPEND
    PROPERTY INCLUDE_DIRECTORIES
        ${WebCore_INCLUDE_DIRECTORIES}
        ${GTK_INCLUDE_DIRS}
        ${GDK_INCLUDE_DIRS}
)

This is not compatible with CMake 2.8.7 (it was introduced in CMake 2.8.8 as indicated here http://www.cmake.org/Wiki/CMake_Version_Compatibility_Matrix/Properties_on_Targets).

Possible solutions:
1. Check for CMake versions below 2.8.8 and throw up an error message indicating that the cmake build system is not compatible with earlier versions
2. Try to work around it by manipulating the includes depending on the target directory

Any thoughts?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.