[Webkit-unassigned] [Bug 132319] CSS JIT: optimize direct / indirect adjacent's traversal backtracking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132319


Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #230473|1                           |0
        is obsolete|                            |




--- Comment #7 from Yusuke Suzuki <utatane.tea at gmail.com>  2014-05-02 12:43:48 PST ---
(From update of attachment 230473)
View in context: https://bugs.webkit.org/attachment.cgi?id=230473&action=review

I've uploaded the revised patch. And add comments on bugzilla to ChangeLog.

>> Source/WebCore/cssjit/SelectorCompiler.cpp:610
>> +static inline BacktrackingAction solveTraversalBacktrackingAction(const SelectorFragment& fragment, bool hasDescendantRelationOnTheRight)
> 
> This is only for adjacent backtracking action, let's name this solveAdjacentTraversalBacktrackingAction() for clarity.

That's reasonable. I've renamed it.

>> LayoutTests/fast/selectors/backtracking-adjacent.html:113
>> +description('The backtracking direct adjacent combinator with descendant tail cases');
> 
> Hum, I am confused here, none of the cases tested needs a descendant tail.
> 
> I think what would make a good test here is cases of adjacent chain inside a descendant chain where a descendant tail would have been needed before your backtracking optimizations.

Right. I've changed this with 'The backtracking from adjacent combinators'.

And added test cases using backtracking tails.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.