[Webkit-unassigned] [Bug 129807] [Win64] Compile error after r165128.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129807


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #226154|review?                     |review-
               Flag|                            |




--- Comment #12 from Mark Lam <mark.lam at apple.com>  2014-03-07 13:25:42 PST ---
(From update of attachment 226154)
View in context: https://bugs.webkit.org/attachment.cgi?id=226154&action=review

Looks much better, but need one more comment so that other folks who look at this will understand why the "|| !ENABLE(LLINT_C_LOOP)" was added, and won't unknowingly remove it.

> Source/WTF/ChangeLog:8
> +        * wtf/Platform.h: MSVC does not support computed goto.

You should also add a comment about the COMPUTED_GOTO_OPCODES e.g.:
"Also enabled COMPUTED_GOTO_OPCODES when !ENABLE(LLINT_C_LOOP).  This is needed because the ASM LLINT operates like COMPUTED_GOTO_OPCODES and relies on the related data structures being defined to support this.  On Win32, the platform does not HAVE_COMPUTED_GOTO support, but does want ENABLE_COMPUTED_GOTO_OPCODES because it uses the ASM LLINT."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.