[Webkit-unassigned] [Bug 129807] [Win64] Compile error after r165128.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129807





--- Comment #6 from Mark Lam <mark.lam at apple.com>  2014-03-07 11:18:15 PST ---
(From update of attachment 226133)
View in context: https://bugs.webkit.org/attachment.cgi?id=226133&action=review

> Source/JavaScriptCore/JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.sh:40
> -# When enabling LLINT and switching to the x86 backend, use "LowLevelInterpreterWin.asm" as output file when running asm.rb.
> +# The return value of LLIntOffsetsExtractor.exe is used to determine
> +# if the C loop backend is enabled, and we should generate LLIntAssembly.h, 
> +# or the x86 backend is enabled, and we should generate LowLevelInterpreterWin.asm
> +
> +${BUILT_PRODUCTS_DIR}/LLIntOffsetsExtractor/LLIntOffsetsExtractor${3}.exe
> +
> +if [ "$?" == "1" ]; then
> +    OUTPUTFILENAME="LowLevelInterpreterWin.asm"
> +else
> +    OUTPUTFILENAME="LLIntAssembly.h"
> +fi
>  
> -/usr/bin/env ruby "${SRCROOT}/offlineasm/asm.rb" "${SRCROOT}/llint/LowLevelInterpreter.asm" "${BUILT_PRODUCTS_DIR}/LLIntOffsetsExtractor/LLIntOffsetsExtractor${3}.exe" "LowLevelInterpreterWin.asm" || exit 1
> +/usr/bin/env ruby "${SRCROOT}/offlineasm/asm.rb" "${SRCROOT}/llint/LowLevelInterpreter.asm" "${BUILT_PRODUCTS_DIR}/LLIntOffsetsExtractor/LLIntOffsetsExtractor${3}.exe" "${OUTPUTFILENAME}" || exit 1

OK, here’s an idea:  note how MSVC sets the env var $BUILT_PRODUCT_DIR.  I think MSVC should already have an env var for 64-bit vs 32-bit.  Use that determine which approach of LLINT you want to take instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.