[Webkit-unassigned] [Bug 129864] Crash shortly after loading certain web pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129864


Aaron Golden <aegolden at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #226086|                            |review?
               Flag|                            |




--- Comment #1 from Aaron Golden <aegolden at gmail.com>  2014-03-06 22:28:48 PST ---
Created an attachment (id=226086)
 --> (https://bugs.webkit.org/attachment.cgi?id=226086&action=review)
Patch prevents shimSecItem{CopyMatching,Add,Update,Delete} from trying to use NULL implementations

Patch prevents the crash by guarding various methods against calling implementations from the secItemShimCallbacks struct when those implementations are NULL.  I'm actually not sure what the most appropriate OSStatus return value is when the callback is NULL.  errSecUnimplemented seemed pretty good, but maybe there's a better/more standard one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.