[Webkit-unassigned] [Bug 129313] Ellipsis is not properly placed for truncated text inside blocks with horizontal border or padding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129313





--- Comment #9 from Zalan Bujtas <zalan at apple.com>  2014-03-06 08:43:41 PST ---
(From update of attachment 225983)
View in context: https://bugs.webkit.org/attachment.cgi?id=225983&action=review

> LayoutTests/ChangeLog:14
> +        * platform/gtk/fast/css/text-overflow-ellipsis-block-with-border-and-padding-expected.png: Added.

You are missing other platforms' expected results.

> LayoutTests/fast/css/text-overflow-ellipsis-block-with-border-and-padding.html:9
> +    padding: 0px 5px 0px 20px;

It would be great to see more test with different combination's of paddings/margins, including negative vales. (left > right, left == right, etc)

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2099
> +                    curr->adjustLogicalPosition(logicalLeft - (availableLogicalWidth - totalLogicalWidth), 0);

Normally availableLogicalWidth <= totalLogicalWidth, so (availableLogicalWidth - totalLogicalWidth) usually ends up being <= 0. Since you are pushing to the right direction starting from logicalLeft, to make it more clear, i'd code it like -> logicalLeft + (totalLogicalWidth - availableLogicalWidth)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.