[Webkit-unassigned] [Bug 129783] [GTK] Close the page when the view is disposed instead of when finalized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129783





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-03-06 01:08:53 PST ---
(In reply to comment #3)
> (From update of attachment 225956 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225956&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:391
> > +    webView->priv->pageProxy->close();
> 
> Hmm, dispose() might be called multiple times, what would happen to the pageProxy if we call close() many times?.

Nothing, there's an early return in WebPageProxy:close();

> I'd better add some condition there.

It's not needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.