[Webkit-unassigned] [Bug 129676] [EFL] Replace GraphicsContext3D with Evas_GL in AcceleratedCompositingContext.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 5 23:15:34 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=129676


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyuyoung.kim at samsung.com




--- Comment #11 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-03-05 23:12:34 PST ---
(In reply to comment #7)

> > > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.h:61
> > > +    OwnPtr<Evas_GL> m_evasGL;
> > 
> > Please use c++11 (e.g. std::unique_ptr<>) instead of OwnPtr.
> 
> I think we should file a new bug to replace OwnPtr<> with unique_ptr<> for EFL objects.
> I can't use unique_ptr<> for Evas_GL right now, 
> because we have to add a custom deleter like deleteOwnedPtr() for OwnPtr<>.
> Fixing this is out of this patch's scope, don't you think?

Ah, I missed to read this comment. If there is additional work to use it, please file a new bug for it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list