[Webkit-unassigned] [Bug 129676] [EFL] Replace GraphicsContext3D with Evas_GL in AcceleratedCompositingContext.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129676





--- Comment #7 from Hyowon Kim <hw1008.kim at samsung.com>  2014-03-05 20:06:34 PST ---
(In reply to comment #5)

> It would be good if you write this reason to ChangeLog.

Done. 

> > > > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.h:44
> > > > +    bool resize(const IntSize&);
> > > 
> > > Why should this function be public ?
> > 
> > If webview size is changed, we will have to resize the EvasGLSurface.
> 
> I don't see well. So, you may call it from other places in future, right ?

Right.

> > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.h:61
> > +    OwnPtr<Evas_GL> m_evasGL;
> 
> Please use c++11 (e.g. std::unique_ptr<>) instead of OwnPtr.

I think we should file a new bug to replace OwnPtr<> with unique_ptr<> for EFL objects.
I can't use unique_ptr<> for Evas_GL right now, 
because we have to add a custom deleter like deleteOwnedPtr() for OwnPtr<>.
Fixing this is out of this patch's scope, don't you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.