[Webkit-unassigned] [Bug 129740] [EFL] Add WK2 API to control TLS error policy on WebContext.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 5 07:55:14 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=129740





--- Comment #3 from Peter Molnar <pmolnar.u-szeged at partner.samsung.com>  2014-03-05 07:52:15 PST ---
(In reply to comment #2)
> Attachment 225884 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:48:  Missing spaces around /  [whitespace/operators] [3]
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:50:  Missing spaces around /  [whitespace/operators] [3]
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:52:  Missing spaces around /  [whitespace/operators] [3]
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:53:  Missing spaces around /  [whitespace/operators] [3]
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:54:  Missing spaces around /  [whitespace/operators] [3]
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:56:  Missing spaces around /  [whitespace/operators] [3]
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:59:  Missing spaces around /  [whitespace/operators] [3]
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:60:  Missing spaces around /  [whitespace/operators] [3]
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:68:  Missing spaces around /  [whitespace/operators] [3]
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:69:  Missing spaces around /  [whitespace/operators] [3]
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:70:  Missing spaces around /  [whitespace/operators] [3]
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_ssl.cpp:71:  Missing spaces around /  [whitespace/operators] [3]
> Total errors found: 12 in 8 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

These style errors are caused by the certificate embedded into the code. This seems to be a better option than including it from a file, this way we can make the test more self-containing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list