[Webkit-unassigned] [Bug 129738] [GTK] MiniBrowser crashes when opening several urls passed as command line options
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 5 07:42:29 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=129738
Sergio Villar Senin <svillar at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #225875|review? |review+
Flag| |
--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> 2014-03-05 07:39:31 PST ---
(From update of attachment 225875)
View in context: https://bugs.webkit.org/attachment.cgi?id=225875&action=review
r=me with comments
> Tools/MiniBrowser/gtk/main.c:286
> + g_object_unref(webkitSettings);
I'd prefer using g_clear_object(&webkitSettings);
We could do the same above when we do:
if (!addSettingsGroupToContext(context, webkitSettings)) {
g_object_unref(webkitSettings);
webkitSettings = 0;
}
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list