[Webkit-unassigned] [Bug 129676] [EFL] Replace GraphicsContext3D with Evas_GL in AcceleratedCompositingContext.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129676


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225851|review?                     |review-
               Flag|                            |




--- Comment #5 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-03-05 01:45:01 PST ---
(From update of attachment 225851)
View in context: https://bugs.webkit.org/attachment.cgi?id=225851&action=review

> TextureMapperGL has its own GraphicsContext3D created by  createForCurrentGLContext(). So AcceleratedCompositingContext doesn't need to create and set it to  TextureMapperGL anymore.
But, we should do 'makeCurrentContext' by using a platform specific context before createForCurrentGLContext().

It would be good if you write this reason to ChangeLog.


This patch removes GraphicsContext3D related codes in AcceleratedCompositingContext and adds EvasGLContext/Surface to it instead.

> Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.h:44
> +    bool resize(const IntSize&);

> > > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.h:44
> > > +    bool resize(const IntSize&);
> > 
> > Why should this function be public ?
> 
> If webview size is changed, we will have to resize the EvasGLSurface.

I don't see well. So, you may call it from other places in future, right ?

> Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.h:61
> +    OwnPtr<Evas_GL> m_evasGL;

Please use c++11 (e.g. std::unique_ptr<>) instead of OwnPtr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.