[Webkit-unassigned] [Bug 25571] DOM range methods setStartBefore/setEndAfter fails on detached elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25571





--- Comment #28 from Ryosuke Niwa <rniwa at webkit.org>  2014-03-05 00:54:55 PST ---
(From update of attachment 225142)
View in context: https://bugs.webkit.org/attachment.cgi?id=225142&action=review

> Source/WebCore/dom/Range.cpp:1211
> -    ec = 0;
> -    checkNodeBA(refNode, ec);
> -    if (ec)
> +    if (!refNode->parentNode()) {
> +        ec = RangeException::INVALID_NODE_TYPE_ERR;
>          return;
> +    }

The spec says "set the start or end" should throw InvalidNodeTypeError if refNode->parentNode() is a doctype.
Where are we checking that now that the call to checkNodeBA has been removed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.