[Webkit-unassigned] [Bug 129676] [EFL] Replace GraphicsContext3D with Evas_GL in AcceleratedCompositingContext.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129676





--- Comment #4 from Hyowon Kim <hw1008.kim at samsung.com>  2014-03-04 21:11:30 PST ---
(In reply to comment #2)
> (From update of attachment 225831 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225831&action=review
> 
> > Source/WebKit/efl/ChangeLog:3
> > +        [EFL] Replace GraphicsContext3D with Evas_GL in AcceleratedCompositingContext.
> 
> Could you explain why we need to replace GraphicsContext3D with Evas_GL ? Any benefit ?

TextureMapperGL has its own GraphicsContext3D created by  createForCurrentGLContext(). So AcceleratedCompositingContext doesn't need to create and set it to TextureMapperGL anymore.
But, we should do 'makeCurrentContext' by using a platform specific context before createForCurrentGLContext().
This patch removes GraphicsContext3D related codes in AcceleratedCompositingContext and adds EvasGLContext/Surface to it instead.

> > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp:69
> > +    int width = 0;
> 
> Please use Evas_Coord to be used by evas_object_geometry_get()
> 
> e.g. Evas_Coord width, height;

Done.

> > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.h:44
> > +    bool resize(const IntSize&);
> 
> Why should this function be public ?

If webview size is changed, we will have to resize the EvasGLSurface.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.