[Webkit-unassigned] [Bug 129676] [EFL] Replace GraphicsContext3D with Evas_GL in AcceleratedCompositingContext.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129676





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-03-04 18:17:45 PST ---
(From update of attachment 225831)
View in context: https://bugs.webkit.org/attachment.cgi?id=225831&action=review

> Source/WebKit/efl/ChangeLog:3
> +        [EFL] Replace GraphicsContext3D with Evas_GL in AcceleratedCompositingContext.

Could you explain why we need to replace GraphicsContext3D with Evas_GL ? Any benefit ?

> Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp:69
> +    int width = 0;

Please use Evas_Coord to be used by evas_object_geometry_get()

e.g. Evas_Coord width, height;

> Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.h:44
> +    bool resize(const IntSize&);

Why should this function be public ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.