[Webkit-unassigned] [Bug 129598] Second execution of navigator.vibration() does not wok.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129598





--- Comment #3 from Jinwoo Song <jinwoo7.song at samsung.com>  2014-03-02 21:52:56 PST ---
(From update of attachment 225632)
View in context: https://bugs.webkit.org/attachment.cgi?id=225632&action=review

> Source/WebCore/ChangeLog:3
> +        m_isVibrate should be set as false, when m_pattern has no element.

Bug title is different from this.

>> Source/WebCore/ChangeLog:7
>> +
> 
> I think that you need to add test case.

It would be good to add explanation for this patch.

> Source/WebCore/Modules/vibration/Vibration.cpp:53
> +    if (m_isVibrating || (length == 1 && !m_pattern[0]))

s/m_pattern/pattern?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.