[Webkit-unassigned] [Bug 129363] Cursor and input text is not updating in vertical-rl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129363





--- Comment #8 from Zalan Bujtas <zalan at apple.com>  2014-03-02 14:36:31 PST ---
(From update of attachment 225222)
View in context: https://bugs.webkit.org/attachment.cgi?id=225222&action=review

> Source/WebCore/ChangeLog:8
> +        Fix repaint rect for position element in writing mode.

This is incorrect wording, you patch changes absolute positioned element behavior only.

> Source/WebCore/rendering/RenderBox.cpp:2109
> +    if (isWritingModeRoot() && !fixed)

Not sure why absolute positioned elements would be an exception here. You should figure it out why it was originally introduced it here -> http://trac.webkit.org/changeset/71851/trunk/WebCore/rendering/RenderBox.cpp

> Source/WebCore/rendering/RenderBox.cpp:4580
> +        rect.setX(std::max(width().toFloat(), style().width().value()) - rect.maxX());

How does this help fix this case? -and why it is only for flipForWritingMode(LayoutRect& rect) and not for the other helpers like flipForWritingMode(FloatRect& rect)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.