[Webkit-unassigned] [Bug 129571] [GTK] Simplify the GObject DOM bindings API break check into one step

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129571





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2014-03-02 11:08:57 PST ---
(In reply to comment #4)

> I haven't said we can't run it, what I've said is that we can't make make check fail. And I think we don't need to move it to make check, but simply run it always.

Yes, the script doesn't return a failing error code ever, right now because of the bug you linked to. The reason I suggest moving it to make check is that after the simplification, it doesn't produce any output file (the current output file is unused and is used more like a stamp). Parts of the build that are tests (ie is the API broken?) and don't produce any output are more like tests. Since the EWS runs "make check" already it seemed okay. If you like though, I can make it part of 'build-webkit' instead. I don't think it makes sense to keep it as part of the default target though, because it doesn't produce any output.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.