[Webkit-unassigned] [Bug 130577] [EFL][WK2]Implement ewk web local storage APIs which has delete function of the local storage entries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130577





--- Comment #27 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-03-31 21:48:48 PST ---
(From update of attachment 228029)
View in context: https://bugs.webkit.org/attachment.cgi?id=228029&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL][WK2]Implement ewk web local storage APIs which has delete function of the local storage entries

[EFL][WK2] Implement ewk APIs of web local storage which have deletion functions of the local storage entries ?

> Source/WebKit2/ChangeLog:14
> +        adding API unittest and fixing memory leak of the existing test case

It looks you just update existing API test. So, I think it is a little correct to change *adding* with *updating*. Besides do you add API unit test to ewk_storage_manager_private.h ?

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:189
> +    storage_timer = ecore_timer_add(1, reinterpret_cast<Ecore_Task_Cb>(timerCallback), &originData);

s/storage_timer/storageTimer/g ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.