[Webkit-unassigned] [Bug 130955] [WebGL][OpenGLES] Enable MSAA support for WebGL Canvas

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130955


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228146|review?                     |review+
               Flag|                            |




--- Comment #3 from Dean Jackson <dino at apple.com>  2014-03-31 17:53:54 PST ---
(From update of attachment 228146)
View in context: https://bugs.webkit.org/attachment.cgi?id=228146&action=review

It would be great if we could write a test for this.

> Source/WebCore/ChangeLog:10
> +        - Imagination OpenGLES GPU Driver alreay support MSAA, so we

Typo: already

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:118
> +        GLint sampleCount = std::min(8, maxSampleCount);
> +        if (sampleCount > maxSampleCount)
> +            sampleCount = maxSampleCount;

You don't need the if clause. sampleCount is already less than or equal to maxSampleCount.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.