[Webkit-unassigned] [Bug 130985] ThemeMac should use std::array instead of IntSize* for control sizes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130985


Beth Dakin <bdakin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Beth Dakin <bdakin at apple.com>  2014-03-31 14:01:56 PST ---
(In reply to comment #2)
> (From update of attachment 228199 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228199&action=review
> 
> > Source/WebCore/platform/mac/ThemeMac.mm:158
> > +static LengthSize sizeFromNSControlSize(NSControlSize nsControlSize, const LengthSize& zoomedSize, float zoomFactor,const std::array<IntSize, 3>& sizes)
> 
> Missing space after comma here.
> 

Ooh, good catch.

> > Source/WebCore/platform/mac/ThemeMac.mm:271
> > +    static const std::array<IntSize, 3> sizes = { {IntSize(14, 14), IntSize(12, 12), IntSize(10, 10)} };
> 
> I think there should be spaces inside the inner "{}" here too, not just the outer ones.

Okay! Fixed.

Thanks, Darin! http://trac.webkit.org/changeset/166523

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.