[Webkit-unassigned] [Bug 130985] ThemeMac should use std::array instead of IntSize* for control sizes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 31 13:57:26 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=130985


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228199|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2014-03-31 13:57:46 PST ---
(From update of attachment 228199)
View in context: https://bugs.webkit.org/attachment.cgi?id=228199&action=review

> Source/WebCore/platform/mac/ThemeMac.mm:158
> +static LengthSize sizeFromNSControlSize(NSControlSize nsControlSize, const LengthSize& zoomedSize, float zoomFactor,const std::array<IntSize, 3>& sizes)

Missing space after comma here.

> Source/WebCore/platform/mac/ThemeMac.mm:271
> +    static const std::array<IntSize, 3> sizes = { {IntSize(14, 14), IntSize(12, 12), IntSize(10, 10)} };

I think there should be spaces inside the inner "{}" here too, not just the outer ones.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list